Jan26 extended logging + AI #30

barluq · 2026-01-09T11:45:38Z

This pull request introduces several improvements and clarifications to the shared TypeScript library, focusing on logging utilities, code helpers, and project documentation. The most important changes include a complete refactor of the logging API for Node.js, new utility functions for working with URLs and timestamps, and the addition of comprehensive coding, build, and testing instructions to the repository. There are also updates to package dependencies and exports for better clarity and usability.

Logging API Refactor:

Replaced the old AppLogger class and pretty stream with a set of simple, stateless logging functions (loggyInfo, loggyDebug, loggyWarn, loggyTrace, loggyFatal, loggyAppStart, loggyRequestReceived, loggyResponseSent) in src/node/logging/logger.ts, standardizing logging across the project. These functions are now exported directly from src/index.node.ts instead of the class. [1] [2]

New Utility Functions:

Added isUrl and isArrayOfUrls helpers to src/globals/coding/code.formating.ts for validating URLs and arrays of URLs, and exported them in src/index.browser.ts. [1] [2]
Introduced nowPlusTime in src/globals/coding/code.dates.ts to get a future/past timestamp by adding seconds, with export in src/index.browser.ts. [1] [2]

Documentation and Coding Guidelines:

Added detailed instructions and repository summaries in .github/copilot-instructions.md, AGENTS.md, .github/instructions/build.instructions.md, .github/instructions/coding.instructions.md, and .github/instructions/testing.instructions.md to clarify project structure, coding style, build strategy, and testing practices. [1] [2] [3] [4]

Package and Build Configuration:

Updated package.json to clean up peer and dev dependencies, add missing type packages, and ensure typescript-eslint is listed as a dev dependency. Removed unnecessary pino-pretty and @rollup/plugin-commonjs. [1] [2] [3]

ESLint Configuration:

Disabled the @typescript-eslint/no-unused-vars rule in eslint.config.mjs for more flexible development.

…te exports

…ports

…ports in index.node.ts; add comprehensive Copilot instructions and build guidelines

- Removed unused peer dependency 'pino-pretty' from peerDependencies. - Cleaned up devDependencies by removing 'barrelsby' and 'typescript-eslint' duplicate entry. - Added '@types/luxon' and '@types/node' to devDependencies for better type support. - Removed the import of '@rollup/plugin-commonjs' from rollup.config.js as it was not being used.

Copilot

Pull request overview

This pull request refactors the logging API in the shared TypeScript library, introduces new utility functions for URL validation and timestamp manipulation, and adds comprehensive project documentation. The major focus is on replacing the old AppLogger class with stateless logging functions that directly use pino, removing the dependency on pino-pretty from the codebase.

Key Changes:

Complete refactor of the logging API from a class-based approach to functional approach with individual logging functions
Addition of URL validation helpers (isUrl, isArrayOfUrls) and timestamp utility (nowPlusTime)
Comprehensive project documentation including coding, build, and testing instructions for AI assistants

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
`src/node/logging/logger.ts`	Replaced `AppLogger` class with stateless logging functions; refactored to use `pino` directly without pretty-printing
`src/index.node.ts`	Updated exports to reflect new logging function names
`src/index.browser.ts`	Added exports for new URL and timestamp utility functions
`src/globals/coding/code.formating.ts`	Added `isUrl` and `isArrayOfUrls` helper functions for URL validation
`src/globals/coding/code.dates.ts`	Added `nowPlusTime` function to calculate future/past timestamps
`package.json`	Removed `pino-pretty`, `@rollup/plugin-commonjs`, and `barrelsby` dependencies; reordered dev dependencies
`rollup.config.js`	Removed unused `@rollup/plugin-commonjs` import
`eslint.config.mjs`	Disabled `@typescript-eslint/no-unused-vars` rule
`AGENTS.md`	Added comprehensive repository documentation for AI assistants
`.github/copilot-instructions.md`	Added GitHub Copilot-specific instructions (duplicate of AGENTS.md)
`.github/instructions/*.md`	Added detailed coding, testing, and build instructions
`package-lock.json`	Automated dependency updates and removals

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-09T11:50:14Z

AGENTS.md

+Shared TypeScript library for backend and frontend applications of the Panther project.
+
+## Important Rule
+Read and folow all `.github/instructions/*` files for code and practises clarity.


Typo: "folow" should be "follow".

Copilot · 2026-01-09T11:50:14Z

AGENTS.md

+
+# Testing and Linting
+- Using Vitest as the test framework and typescript for type safety.
+- Please folow `.github/instructions/testing.instructions.md` for testing-related guidelines.


Typo: "folow" should be "follow".

Copilot · 2026-01-09T11:50:14Z

.github/copilot-instructions.md

+Shared TypeScript library for backend and frontend applications of the Panther project.
+
+## Important Rule
+Read and folow all `.github/instructions/*` files for code and practises clarity.


Typo: "folow" should be "follow".

Copilot · 2026-01-09T11:50:15Z

.github/instructions/coding.instructions.md

+applyTo: "src/**/*.ts"
+---
+
+# General programming style guidlines for this repository


Typo: "guidlines" should be "guidelines".

Suggested change

# General programming style guidlines for this repository

# General programming style guidelines for this repository

Copilot · 2026-01-09T11:50:15Z

AGENTS.md

+- Functions to parse and validate Arrows.app JSON format (`src/node/api/parse.arrows.json.ts`).
+- Utility functions for parsing and validating raw input data (`src/node/api/parse.raw.input.ts`).
+- Global types and interfaces shared between frontend and backend (`src/globals/arrows/`, `src/globals/panther/`).
+- General shared coding helpers and formaters (`src/globals/coding/`)


Typo: "formaters" should be "formatters".

Suggested change

- General shared coding helpers and formaters (`src/globals/coding/`)

- General shared coding helpers and formatters (`src/globals/coding/`)

Copilot · 2026-01-09T11:50:15Z

.github/copilot-instructions.md

+- Functions to parse and validate Arrows.app JSON format (`src/node/api/parse.arrows.json.ts`).
+- Utility functions for parsing and validating raw input data (`src/node/api/parse.raw.input.ts`).
+- Global types and interfaces shared between frontend and backend (`src/globals/arrows/`, `src/globals/panther/`).
+- General shared coding helpers and formaters (`src/globals/coding/`)


Typo: "formaters" should be "formatters".

Suggested change

- General shared coding helpers and formaters (`src/globals/coding/`)

- General shared coding helpers and formatters (`src/globals/coding/`)

Copilot · 2026-01-09T11:50:16Z

src/node/logging/logger.ts

+export const loggyInfo = (label: string, message: string, options: Record<string, any> = {}): void => {
+  buildBaseLogger().info({ ...options, label, message })


A new pino logger instance is created on every log call by invoking buildBaseLogger(). This is inefficient and should be avoided. Consider creating the logger once at module scope and reusing it across all logging functions. This will improve performance and reduce memory overhead.

@copilot open a new pull request to apply changes based on this feedback

Copilot · 2026-01-09T11:50:16Z

src/node/logging/logger.ts

+  route: string,
+  method: string,
+  options: Record<string, any> = {}) => {
+  loggyInfo("Request Recived", `${method}: ${route}`, options)


Typo in the label: "Recived" should be "Received".

Suggested change

loggyInfo("Request Recived", `${method}: ${route}`, options)

loggyInfo("Request Received", `${method}: ${route}`, options)

Copilot · 2026-01-09T11:50:16Z

.github/copilot-instructions.md

+
+# Testing and Linting
+- Using Vitest as the test framework and typescript for type safety.
+- Please folow `.github/instructions/testing.instructions.md` for testing-related guidelines.


Typo: "folow" should be "follow".

Copilot · 2026-01-09T11:56:20Z

@barluq I've opened a new pull request, #31, to work on those changes. Once the pull request is ready, I'll request review from you.

…scope Co-authored-by: barluq <[email protected]>

Co-authored-by: barluq <[email protected]>

Optimize logger by creating single pino instance at module scope

barluq added 7 commits January 2, 2026 13:29

Add isUrl function to validate URL strings and update exports

4d9cc0f

Add isArrayOfUrls function to validate arrays of URL strings and upda…

497b53e

…te exports

Add nowPlusTime function to calculate future timestamps and update ex…

b77c947

…ports

Refactor logger module to enhance logging functionality and update ex…

07fea4a

…ports in index.node.ts; add comprehensive Copilot instructions and build guidelines

Update Copilot instructions to include delivered features and utilities

d52c383

fix: disable no-unused-vars rule in ESLint configuration

391c5b5

barluq requested review from Copilot and mbabic84 January 9, 2026 11:46

Copilot started reviewing on behalf of barluq January 9, 2026 11:46 View session

Copilot AI reviewed Jan 9, 2026

View reviewed changes

barluq and others added 3 commits January 9, 2026 12:53

fix: correct spelling errors in Copilot instructions

8fbd10e

fix: correct spelling errors in documentation and logging

5d22666

Initial plan

605e88a

Copilot AI mentioned this pull request Jan 9, 2026

Optimize logger by creating single pino instance at module scope #31

Merged

barluq and others added 5 commits January 9, 2026 12:59

chore: remove outdated barrelsby.json configuration file

6f0e9a3

refactor: optimize logger by creating single pino instance at module …

9ff53a1

…scope Co-authored-by: barluq <[email protected]>

fix: correct spelling of 'Received' in loggyRequestReceived

25ae442

Co-authored-by: barluq <[email protected]>

Merge pull request #31 from Gisat/copilot/sub-pr-30

e485a09

Optimize logger by creating single pino instance at module scope

fix: remove unused ESLint rule and clean up logger code

9713e44

mbabic84 approved these changes Jan 9, 2026

View reviewed changes

barluq merged commit cc4b9d5 into dev Jan 9, 2026
2 checks passed

barluq deleted the jan25-extended-validation branch January 9, 2026 13:27

	# General programming style guidlines for this repository
	# General programming style guidelines for this repository

	- General shared coding helpers and formaters (`src/globals/coding/`)
	- General shared coding helpers and formatters (`src/globals/coding/`)

		export const loggyInfo = (label: string, message: string, options: Record<string, any> = {}): void => {
		buildBaseLogger().info({ ...options, label, message })

	loggyInfo("Request Recived", `${method}: ${route}`, options)
	loggyInfo("Request Received", `${method}: ${route}`, options)

Jan26 extended logging + AI #30

Jan26 extended logging + AI #30

Uh oh!

Conversation

barluq commented Jan 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

barluq Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jan 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants